Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate output patch #56

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

sletort
Copy link
Contributor

@sletort sletort commented Mar 17, 2017

Here is the patch for output as describe in issue #55
As mentionned it's a big changed.

  • check_kmer_overlap has been renamed compute_kmer_overlap as you suggested. I placed it outside Scaffold class.
  • I had some tool classes : Component, Contig, and Gap. I think they can help code reading.
  • Scaffold does not compute gaps,positions,directions, ... as list. The main computation (those list construction and the N integration, previously in make_fasta) has been placed in __buildComponents
  • Those changes make output generation quite easy to understand I think. I place a description of rows for AGP and GFF in docstring comment.

I checked on my assembly that fasta output has not been altered.

I also made a unittest branch which I'll proposed to add to your repository in another pull request.
Sébastien

LETORT Sebastien added 9 commits March 10, 2017 14:48
… initialization. make_* methods are only used to generate the output. New tiny classes have been added to managed Scaffold components.
…tired when I did -= 0 :/ (anyway, I'm not sure that we need to destroy Components).
conflict resolution => print takes its parenthesis.
This reverts commit 0da91f1.
This commit concerned generateOutput_patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant